More lottie fixes#137
Open
kunitoki wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 79.32% 79.32% -0.01%
==========================================
Files 712 712
Lines 70398 70411 +13
==========================================
+ Hits 55846 55853 +7
- Misses 14552 14558 +6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the "Auto-Orient" feature in Lottie animation layers, ensuring that layers can align their local X axis with their instantaneous motion path, as specified by the Lottie
"ao"property. The implementation includes updates to the animation transform logic, Lottie file parsing and serialization, and comprehensive tests to verify correct behavior and roundtrip preservation.Auto-Orient Feature Implementation
autoOrientproperty to theAnimationTransformclass, and updated thetoAffineTransformmethod to rotate the layer according to its motion path whenautoOrientis enabled. [1] [2]"ao"(auto-orient) property for each layer, ensuring that this setting is preserved when reading and writing Lottie files. [1] [2]Renderer Logic Improvements
Testing Enhancements
Test Data
bell.jsonLottie file to the test data for validating solid color and auto-orient parsing.