Skip to content

Improved Lottie support#133

Merged
kunitoki merged 12 commits into
mainfrom
dev/faster_lottie
Jul 10, 2026
Merged

Improved Lottie support#133
kunitoki merged 12 commits into
mainfrom
dev/faster_lottie

Conversation

@kunitoki

Copy link
Copy Markdown
Owner

Current rendering fail rate: 13/94

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.09756% with 306 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.23%. Comparing base (6faa76e) to head (9f73778).

Files with missing lines Patch % Lines
...s/yup_animation/renderer/yup_AnimationRenderer.cpp 50.43% 169 Missing ⚠️
modules/yup_animation/io/yup_LottieReader.cpp 54.09% 56 Missing ⚠️
...nimation/renderer/yup_AnimationRenderResources.cpp 0.00% 19 Missing ⚠️
...ules/yup_animation/core/yup_AnimationTransform.cpp 60.52% 15 Missing ⚠️
...odules/yup_animation/model/yup_AnimationModifier.h 7.14% 13 Missing ⚠️
modules/yup_animation/core/yup_AnimationProperty.h 20.00% 8 Missing ⚠️
modules/yup_animation/model/yup_AnimationPaint.cpp 75.00% 7 Missing ⚠️
modules/yup_animation/model/yup_AnimationShape.cpp 83.33% 6 Missing ⚠️
modules/yup_graphics/context/yup_OffscreenTarget.h 20.00% 4 Missing ⚠️
...es/yup_animation/animation/yup_AnimationPlayer.cpp 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   79.47%   79.23%   -0.24%     
==========================================
  Files         703      708       +5     
  Lines       69695    70207     +512     
==========================================
+ Hits        55387    55626     +239     
- Misses      14308    14581     +273     
Files with missing lines Coverage Δ
modules/yup_animation/animation/yup_Animation.cpp 100.00% <100.00%> (ø)
modules/yup_animation/animation/yup_Animation.h 100.00% <ø> (ø)
modules/yup_animation/core/yup_AnimationEasing.cpp 98.59% <100.00%> (+0.10%) ⬆️
modules/yup_animation/core/yup_AnimationEasing.h 100.00% <ø> (ø)
...odules/yup_animation/core/yup_AnimationTransform.h 100.00% <100.00%> (ø)
modules/yup_animation/model/yup_AnimationGroup.cpp 100.00% <100.00%> (ø)
modules/yup_animation/model/yup_AnimationGroup.h 90.00% <ø> (ø)
modules/yup_animation/model/yup_AnimationLayer.h 71.42% <ø> (ø)
modules/yup_animation/model/yup_AnimationPaint.h 50.00% <ø> (ø)
modules/yup_animation/model/yup_AnimationShape.h 100.00% <100.00%> (ø)
... and 21 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6faa76e...9f73778. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki merged commit 3415ac0 into main Jul 10, 2026
39 of 40 checks passed
@kunitoki kunitoki deleted the dev/faster_lottie branch July 10, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant