Skip to content

Rename eigen to eigen_library#132

Merged
kunitoki merged 1 commit into
mainfrom
dev/rename_eigen
Jul 9, 2026
Merged

Rename eigen to eigen_library#132
kunitoki merged 1 commit into
mainfrom
dev/rename_eigen

Conversation

@kunitoki

@kunitoki kunitoki commented Jul 9, 2026

Copy link
Copy Markdown
Owner

This pull request updates the handling and naming of the Eigen library integration throughout the codebase, ensuring consistency and clarity in module references. Additionally, it updates a type trait in a static assertion to improve standards compliance.

Key changes include:

Eigen Library Integration and Naming Consistency:

  • Renamed the Eigen module from eigen to eigen_library in the module declaration and updated all references accordingly, including in thirdparty/eigen_library/eigen_library.h [1] modules/yup_simd/yup_simd.h [2] [3] modules/yup_simd/types/yup_EigenAdapters.h [4] and thirdparty/bungee_library/bungee_library.h [5].

Code Standards and Type Safety:

  • Changed the static assertion in getDataPtrAndSize from std::is_pod_v<T> to std::is_standard_layout_v<T> for improved standards compliance and compatibility with non-POD, standard-layout types (modules/yup_audio_devices/native/yup_CoreAudio_mac.cpp).

@kunitoki kunitoki added the breaking change Breaking public API label Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.46%. Comparing base (21a4276) to head (0342812).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   79.44%   79.46%   +0.01%     
==========================================
  Files         703      703              
  Lines       69666    69666              
==========================================
+ Hits        55348    55359      +11     
+ Misses      14318    14307      -11     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5246dbd...0342812. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki merged commit 6faa76e into main Jul 9, 2026
40 checks passed
@kunitoki kunitoki deleted the dev/rename_eigen branch July 9, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Breaking public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant