fix: remove Thread.sleep() from DefaultWorkQueueTest

[sarveshkaushal]

Notes

This change removes the Thread.sleep() dependency on the DefaultWorkQueueTest and replaces it with explicit thread synchronization.. This is related to issue #1223

Testing

Ran mvn install from project root and build completed successfully.

[sarveshkaushal]

/assign @brendandburns
/assign @yue9944882

[brendandburns]

I think there are a lot of whitespace changes that make this hard to review because it makes the diff much bigger than it needs to be.

Please minimize the diff and then I can do a real review.

[sarveshkaushal]

@brendandburns - Thanks for pointing that out. I ran IntelliJ's code formatter on the file, so the formatting in the changed section is formatter-generated rather than intentional whitespace changes. I checked the Git diff as well, and there don't appear to be whitespace-only changes outside the modified test.

[brendandburns]

The git diff makes this pretty hard to review. With changes like this that modify the thread synchronization stuff and modify a unit test, minimizing the diff really makes a big difference in reviewability. Can you take a stab at trying to minimize, for example remove the changes to import ordering.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sarveshkaushal
Once this PR has been reviewed and has the lgtm label, please ask for approval from brendandburns. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sarveshkaushal]

@brendandburns - I have fixed the formatting changes.

[brendandburns]

I don't see a sleep in this test and I think the structure of the test is pretty fundamentally changed. Revert changes to this test?

[sarveshkaushal]

Agreed. I have undone the changes in this test.