Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aliok The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part 2 of splitting the original KEDA Kafka scaling work (#4051) into reviewable
pieces. This adds the
scale.kedasurface — KEDA scaler types and triggers —and the KEDA deployer implementation for Kafka consumer-lag scaling.
scalefield to func.yaml #4063 (merged) — Part 1: top-levelscalefield withscale.min/maxandscale.kpaplus migration. This PR stacks on that and is now rebased directlyonto
main.Changes
ScaleOptions.KEDA(KEDAScaleOptions+KEDATrigger):pollingInterval,cooldownPeriod, andtriggers(typehttp/kafka, withtargetValue,lagThreshold,activationLagThreshold).scale.keda/scale.kpaare mutually exclusive;scale.kedarequires
deployer: kedaandscale.kparequiresdeployer: knative. Kafkatriggers require a
run.kafkaconfig. Bounds-checked numeric fields.pkg/keda/kafka_scaling.go) — builds theScaledObjectand,when SASL/TLS is configured, a
TriggerAuthentication, both owner-referenced tothe Deployment so they are garbage-collected on delete.
when no HTTPScaledObject is present (kafka scaler case).
observed state (
f.Deploy.ScalerType), mirroring the existingDeployer/Exposepattern (written back only on a successful deploy, cleared only on a successful
remove).
Design decision: refuse in-place scaler/trigger-type switches
Unlike #4051, this PR refuses switching the deployer, scaler type, or trigger
type (http↔kafka) on an already-deployed function — the user must
func deletefirst. Switching in place could orphan a second scaler on the same Deployment while
Deploy reports success (owner-ref GC can't reclaim it because the Deployment
survives). Same-type parameter tweaks (lagThreshold, topic, consumerGroup,
pollingInterval, …) still update the existing
ScaledObjectin place — no deleterequired.
Behavior tightening
run.kafka.sasl.mechanismis now required when SASL is configured (previously anempty mechanism was silently accepted). Flagging explicitly for reviewers.
Related issue
WaitForDeploymentAvailableerrors on a 0-replica Deployment (kedascale-to-zero redeploy race). Reasoned from code, repro TBD; deliberately out of
scope here to keep this PR focused on the
scale.kedasurface. Filed separatelywith a suggested fix.
Testing
gate (
ValidateScalerSwitchtruth table +Client.Deployrefuse/allow cases), andobserved-state integrity on remove failure.
//go:build integration) that deploys a Kafka-only function andasserts the
ScaledObject+TriggerAuthenticationare created.go build,go vet, and unit tests forpkg/functions,pkg/keda,pkg/deployerspass.