✅ tests: drop stale setuptools assertion#3323
Merged
AndreMiras merged 1 commit intokivy:developfrom May 9, 2026
Merged
Conversation
setuptools was added to setup.py install_reqs in kivy#3007 (May 2024), so it now appears as a direct (non-recursive) dependency. The assertion at test_pythonpackage.py:46 ("setuptools not in deps_nonrecursive") has been wrong since then but went unnoticed because the file is skipped in CI (`make test` uses `--ignore tests/test_pythonpackage.py`). The remaining `include_build_requirements=True` assertion still exercises the build-deps code path. Note this test is skipped by the CI but was ran manually upon during pre-release checks. This can be reproduced via: ``` pytest tests/test_pythonpackage.py::test_get_package_dependencies ``` The error was: ```` > assert "setuptools" not in deps_nonrecursive E AssertionError: assert 'setuptools' not in {'appdirs', 'build', 'colorama>=0.3.3', 'jinja2', 'meson', 'ninja', ...} ```
Member
Author
|
Getting these shipped in the release, so merging fast (skipping review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools was added to setup.py install_reqs in #3007 (May 2024), so it now appears as a direct (non-recursive) dependency. The assertion at test_pythonpackage.py:46 ("setuptools not in deps_nonrecursive") has been wrong since then but went unnoticed because the file is skipped in CI (
make testuses--ignore tests/test_pythonpackage.py).The remaining
include_build_requirements=Trueassertion still exercises the build-deps code path.Note this test is skipped by the CI but was ran manually upon during pre-release checks. This can be reproduced via:
The error was: