[Widgets] Fix check for root item in container

[kimkulling]

Summary by CodeRabbit

• Bug Fixes
  • Corrected widget container initialization logic to properly prevent container creation when a root element is missing.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d22e4f65-748d-41f8-9716-4238ebc8a0f5

📥 Commits

Reviewing files that changed from the base of the PR and between 355dda9 and 861e5bc.

📒 Files selected for processing (1)

• src/widgets.cpp

---

Walkthrough

This PR inverts a single guard condition in the Widgets::container function. The check for root existence is flipped: previously, the function returned InvalidId when root was non-null; now it returns InvalidId when root is null, blocking container creation without an initialized root.

Changes

Container Root Guard Inversion

Layer / File(s)	Summary
Container root initialization guard inversion src/widgets.cpp	Guard condition in Widgets::container is inverted from ctx.mRoot != nullptr to ctx.mRoot == nullptr, reversing the control flow that determines when container creation is blocked.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing the root item check in the container initialization logic within the Widgets module.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/kk/widgets_fix_container_root_check

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud