#199 - remove all oss.sonatype.org references in code#200
Merged
Conversation
Needed because seems like with JDK21, writing to /var throws "Caused by: java.io.IOException: Permission denied" FYI by default, the KpmProperties define bundles at /var/tmp/bundles
There was a problem hiding this comment.
Pull request overview
This PR updates the KPM bundle to stop using oss.sonatype.org for fetching Maven artifacts/metadata, switching defaults and test configuration to Maven Central (repo1.maven.org) to avoid flaky redirects and CI failures (Issue #199).
Changes:
- Switch KPM default Nexus/Maven base URL + repository defaults from Sonatype OSS to Maven Central (
repo1.maven.org/maven2). - Update URL resolver logic and coordinate-based plugin downloader to use Maven Central public release URL.
- Update tests and configuration documentation to reflect the new Maven Central endpoints.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| osgi-bundles/bundles/kpm/src/test/java/org/killbill/billing/osgi/bundles/kpm/impl/TestDefaultPluginManager.java | Use shared test properties helper for consistent test setup. |
| osgi-bundles/bundles/kpm/src/test/java/org/killbill/billing/osgi/bundles/kpm/impl/TestDefaultNexusMetadataFiles.java | Point metadata tests at Maven Central instead of Sonatype OSS. |
| osgi-bundles/bundles/kpm/src/main/java/org/killbill/billing/osgi/bundles/kpm/KpmProperties.java | Update default Nexus URL/repository defaults to Maven Central. |
| osgi-bundles/bundles/kpm/src/main/java/org/killbill/billing/osgi/bundles/kpm/impl/UrlResolverFactory.java | Simplify resolver creation now that defaults are valid without Sonatype-specific rewriting. |
| osgi-bundles/bundles/kpm/src/main/java/org/killbill/billing/osgi/bundles/kpm/impl/DefaultNexusMetadataFiles.java | Remove OSS special-casing and add explicit rejection of OSS URLs. |
| osgi-bundles/bundles/kpm/src/main/java/org/killbill/billing/osgi/bundles/kpm/impl/CoordinateBasedPluginDownloader.java | Switch public fallback repository to Maven Central and reject OSS base URIs. |
| osgi-bundles/bundles/kpm/spotbugs-exclude.xml | Suppress SpotBugs warning for constructor throwing due to new validation. |
| osgi-bundles/bundles/kpm/CONFIGURATION.md | Update documented defaults and examples to Maven Central. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reshmabidikar
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #199 . Commit are self-explanatory.
One commit back-ported from
masterin test area (we can create new commit, it affect nothing other than fixing the test): f2ea0c8