Kaui 6.24#618
Merged
Merged
Conversation
…s and update related tests
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Kaui to improve subscription management UX and functionality: recording usage now better guides unit selection and date entry, bundle search no longer shows a “no bundles” message when not searching, and subscription creation/update supports multi-phase price overrides.
Changes:
- Improve “Record Usage” UI/validation flow (unit type selection, datetime input, updated error messaging).
- Replace single
price_overridewith multi-entryprice_overridesacross create/update flows and UI. - Only show “No bundles found” message when a search query is present.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/functional/kaui/subscriptions_controller_test.rb | Updates functional tests for new usage-date validation message and multi-phase price override params. |
| app/views/kaui/subscriptions/record_usage.erb | Enhances record-usage form (unit type selection, datetime input, removes reason/comment fields). |
| app/views/kaui/subscriptions/_form.html.erb | Adds multi-phase price override UI for subscription creation. |
| app/views/kaui/subscriptions/_edit_form.html.erb | Adds multi-phase price override UI for subscription plan change. |
| app/views/kaui/bundles/index.html.erb | Suppresses “No bundles found” message unless searching. |
| app/controllers/kaui/subscriptions_controller.rb | Implements server-side multi-phase price overrides, unit type extraction, and more flexible usage date parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix the Edit colums
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #620 #237 #615 #594