Repository navigation
feat(http): include OS family in User-Agent - #318
Merged
Merged
Conversation
Coarse OS in the kci-dev UA supports dashboard client analytics (kernelci/dashboard#2144). Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
alanpeixinho
force-pushed
the
feat/user-agent-os-family
branch
from
October 1, 2026 17:50
7935168 to
e4a1abc
Compare
Member
|
Looks good overall. I’d just suggest strengthening the tests before merging. The current assertion builds the expected User-Agent using Could we add explicit tests for at least:
It may also be worth mapping only the OS families supported by the dashboard and returning |
* Assert Linux, Darwin, Windows, and an empty value directly. * Report unknown for any OS outside Linux, macOS, and Windows. Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
Contributor
Author
|
Thanks @aliceinwire, I updated the PR addressing your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
python -c "from kcidev.libs.common import kcidev_session; print(kcidev_session.headers['User-Agent'])"