Open
Conversation
aliceinwire
reviewed
Apr 24, 2026
| ) | ||
| # Delay before retrying, to prevent hammering the server with exponential backoff | ||
| time.sleep(2 ** retries) | ||
| time.sleep(2**retries) |
Member
There was a problem hiding this comment.
why adding a commit and fixing it in a second commit?
just fix this on your first commit
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
While possibility of this exception low, we need to detect this situation as error by kci-dev returning proper exit code. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Member
Author
|
Fixed. Pre-commit checks will really help on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just noticed small issues that are worth to fix:
1)One of them potentially might flood servers if will work in automated mode in script
2)Second will help to detect/propagate error properly