Repository navigation
fix(test-details): preserve test origin in hardware links - #2223
Merged
nuclearcat merged 1 commit intoNov 9, 2026
Merged
Conversation
Set the test-origin filter on Hardware and Compatibles links so cross-origin results do not inherit unrelated checkout and build defaults. Cover new tabs, shared URLs, stale search state, and reloads with browser regression tests. Closes kernelci#2000 Assisted-by: Codex Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Member
Author
|
Visual evidence from the local frontend with deterministic TI test data. Both Hardware and Compatibles links include The four Playwright checks also verify the resulting boot/test origin filters in the hardware-summary request, including copied URLs and reloads. This screenshot is not a production-results check. |
alanpeixinho
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The Hardware and Compatibles links on Test Details omit the test origin. Following a TI result can therefore open hardware details with unrelated default filters and show no results.
Both links now set the existing
testOriginURL filter fromtest.test_origin. This uses the current hardware route's filter format and lets checkout/build origins remain unrestricted, since a TI test can belong to a Maestro build. The component change adds six lines and removes two.Closes #2000.
Validation
The browser tests mock API responses and verify the actual hardware-summary request body. They do not verify backend result counts. The screenshot in the PR comment uses fixture data.
Reproduce
From
dashboard/, runpnpm install --frozen-lockfileandpnpm exec playwright install chromiumif needed.VITE_API_BASE_URL=http://127.0.0.1:5173 pnpm dev --host 127.0.0.1 --port 5173.PLAYWRIGHT_TEST_BASE_URL=http://127.0.0.1:5173 pnpm e2e test-hardware-links.spec.ts. No backend is needed for these tests.df%7Cto%7Cti=true. The summary request should containfilter_boot.origin: ["ti"]andfilter_test.origin: ["ti"], without default checkout/build origin filters. Copy the URL into a fresh tab and reload it; the filters should persist.Date-window behavior is unchanged. The original July test still exists in production, but its July
hardware_statusentry is absent, so forcing the old July window remains outside this fix. Production currently runs the older origin-based route; this PR targets currentmainand should be deployed with its filter changes.