Repository navigation
fix(test-details): show tree breadcrumbs without navigation context - #2222
Open
nuclearcat wants to merge 1 commit into
Open
nuclearcat wants to merge 1 commit into
nuclearcat wants to merge 1 commit into
Conversation
Use the test's checkout metadata for fallback breadcrumb links and preserve existing Hardware and Trees navigation. Keep the details label unlinked when the commit hash is missing. Issue kernelci#2001 has remained unaddressed for some time, so I am taking over the fix. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Member
Author
|
Local browser verification with deterministic API responses. The first screenshot shows a directly opened test with the Trees fallback; the second shows preserved Hardware navigation context. All five breadcrumb browser tests passed.
|
felipebergamin
approved these changes
Nov 9, 2026
felipebergamin
left a comment
felipebergamin
left a comment
Member
There was a problem hiding this comment.
just a small nit. No blockers.
Comment on lines
+595
to
+614
| {breadcrumb ?? | ||
| (data && ( | ||
| <MemoizedTreeBreadcrumb | ||
| locationMessage="test.details" | ||
| tree={{ | ||
| treeName: data.tree_name, | ||
| branch: data.git_repository_branch, | ||
| id: data.git_commit_hash, | ||
| }} | ||
| searchParams={{ | ||
| origin: data.origin, | ||
| treeInfo: { | ||
| treeName: data.tree_name, | ||
| gitBranch: data.git_repository_branch, | ||
| gitUrl: data.git_repository_url, | ||
| headCommitHash: data.git_commit_hash, | ||
| }, | ||
| }} | ||
| /> | ||
| ))} |
Member
There was a problem hiding this comment.
the component is memoized but tree and searchParams are recreated on every render. This practically negates memoization
alanpeixinho
approved these changes
Nov 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a copied test URL currently removes the breadcrumb row because the page depends on browser history state. This change shows
Trees > Trees Details > Test Detailsusing the test's checkout metadata when that context is missing.Existing Hardware and Trees navigation keeps its breadcrumbs. Fallback links use the checkout origin rather than stale listing state or the test origin. If the commit hash is missing, Trees Details stays visible as text without a broken link.
Issue #2001 has remained unaddressed for some time, so I am taking over the fix.
Closes #2001.
Validation
Reproduce
From
dashboard/, install dependencies withpnpm install --frozen-lockfileand install Chromium withpnpm exec playwright install chromiumif needed.VITE_API_BASE_URL=http://127.0.0.1:5173 pnpm dev --host 127.0.0.1 --port 5173.PLAYWRIGHT_TEST_BASE_URL=http://127.0.0.1:5173 pnpm e2e test-breadcrumb.spec.ts. These tests provide their own API responses, so no backend is needed.