[codex] add platform flag for images and runs#54
Draft
rgarcia wants to merge 1 commit into
Draft
Conversation
ec08ca3 to
f1a9bea
Compare
f1a9bea to
4a26c20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--platformflag to the Hypeman CLI for image creation/pull and instance creation.This lets local macOS users exercise the Rosetta support from hypeman PR 279 directly through the CLI, for example:
Details
--platformtohypeman image createandhypeman pull.--platformtohypeman run.runwhen the image is missing.option.WithJSONSetbecause the currently generatedhypeman-goversion does not yet expose typedplatformfields.Server-side instance creation is responsible for resolving/validating the requested platform when an image tag already exists locally.
Validation