Skip to content

Add basic auth support and error check for http(s) handlers#54

Open
drunkbatya wants to merge 4 commits into
keeprocking:masterfrom
flipperdevices:master
Open

Add basic auth support and error check for http(s) handlers#54
drunkbatya wants to merge 4 commits into
keeprocking:masterfrom
flipperdevices:master

Conversation

@drunkbatya

@drunkbatya drunkbatya commented Sep 25, 2023

Copy link
Copy Markdown
  • Add basic auth support and error check for GelfHttpHandler and GelfHttpsHandler

@keeprocking

Copy link
Copy Markdown
Owner

Hi, I'll look into it this week.

Thank you.

Comment thread pygelf/handlers.py Outdated
@drunkbatya drunkbatya changed the title Add basic auth support, add http code check Add basic auth support Dec 11, 2023
@drunkbatya drunkbatya changed the title Add basic auth support Add basic auth support and error check for http(s) handlers Dec 11, 2023
@drunkbatya

drunkbatya commented Dec 11, 2023

Copy link
Copy Markdown
Author

I added an error checks again, through try/catch construction, and also assert for status code to catch unauthorized and other https errors. I replaced throwing exceptions with native logging's self.handleError(record) . This also may close issue 52.

@drunkbatya

Copy link
Copy Markdown
Author

@keeprocking does I need to make any changes before merge may occur?

@keeprocking

Copy link
Copy Markdown
Owner

Hi, sorry for the delay - I'm currently undergoing medical treatment and will get back to this as soon as possible. No exact time frame, sorry.

@chilledornaments

Copy link
Copy Markdown

@drunkbatya would you mind adding tests for this functionality? I believe you need to add new inputs here and more params to tests/test*.py (for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants