fix(install): hint flue restart when updating - #119
Merged
Conversation
install.sh serves first installs and updates alike. After an update the daemon keeps running the old build until restarted, so the closing hint must say restart, not enable, when a flue binary already sits at the install path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
install.shcloses withnext: flue enableunconditionally, but the same script serves updates over an existing install. After an update the running daemon keeps executing the old build until it is restarted, soflue enable(which deliberately never restarts a healthy daemon) is the wrong hint.How
${INSTALL_DIR}/flue. If one is there, the run is an update and the closing hint becomesnext: flue restart. Fresh installs keepnext: flue enable.install_binary, otherwise every install would look like an update. The dry-run path prints the same hint.Tests
scripts/install_test.sh: a dry-run against an install dir that already holds an executablefluemust end withnext: flue restartand must not mentionflue enable. Watched it fail before the fix.bash scripts/install_test.sh: all 23 assertions pass.shellcheck scripts/install.sh scripts/install_test.sh: clean.🤖 Generated with Claude Code