Add SchedulerHints to server controller#632
Merged
mandre merged 3 commits intok-orc:mainfrom Apr 23, 2026
Merged
Conversation
Contributor
winiciusallan
left a comment
winiciusallan
left a comment
There was a problem hiding this comment.
Looks good overall! Great job! Just a few comments. Let me know what you think.
eshulman2
force-pushed
the
shints
branch
10 times, most recently
from
7b0df63 to
bdf5e4f
Compare
mandre
reviewed
Jan 15, 2026
mandre
reviewed
Jan 16, 2026
eshulman2
force-pushed
the
shints
branch
2 times, most recently
from
f6e8392 to
8894f8f
Compare
eshulman2
force-pushed
the
shints
branch
6 times, most recently
from
4bc925c to
54a3ad6
Compare
eshulman2
force-pushed
the
shints
branch
2 times, most recently
from
ce7d860 to
d979876
Compare
Contributor
There was a problem hiding this comment.
Thanks for your effort, @eshulman2!
To me, it is very close to a merge state, I just left a comment on the dependency that you added, let me know what you think.
mandre
reviewed
Jan 19, 2026
Collaborator
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
I believe this is almost ready. I would still like to keep this for a little longer in the queue to make up my mind about the breaking/non-breaking change.
mandre
approved these changes
Jan 21, 2026
mandre
approved these changes
Apr 17, 2026
mandre
reviewed
Apr 17, 2026
| reconcileStatus := progress.NewReconcileStatus() | ||
|
|
||
| // Resolve ServerGroupRef to server group ID | ||
| sg, sgReconcileStatus := dependency.FetchDependency( |
Collaborator
There was a problem hiding this comment.
We'll want to rework this dependency fetch after #674 merges.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
- Add SchedulerHints to server controller - enable required nova filters for testing hints NOTE! this change MOVED the ServerGroupRef inside the ServerSchedulerHints
Since IsAvailable implies Status.ID is set, the redundant check for Status.ID != nil can be removed. Pass orcv1alpha1.IsAvailable directly as the filter function for the ServerGroup and boot Volume dependencies, consistent with the changes made in all other controllers.
mandre
approved these changes
Apr 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
|
The test failure is due to a name clash in the namespaces as generated by kuttl. I'll work on a kuttl fix. |
Collaborator
|
Kuttl fix submitted at kudobuilder/kuttl#682, for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add schedulerHints field with support for:
NOTE! this change MOVED the ServerGroupRef inside the ServerSchedulerHints