Repository navigation
Conversation
cp-20
marked this pull request as ready for review
October 9, 2026 09:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
evalCode(src, file, { type: "module", compileOnly: true })reads an uninitialized pointer inQTS_Eval.moduleis only assigned on the evaluate path. WithcompileOnly,JS_Evalreturns the compiled module (JS_TAG_MODULE), which is not an exception and has the module flag set, so it falls through to the namespace conversion: the result is freed andJS_GetModuleNamespace(ctx, module)is called with garbage.What
Return compile-only results before the module namespace/promise handling, the same way global compile-only code is already returned. The caller owns and disposes the handle.
Notes
Ran
quickjs.test.tsfor quickjs release/debug (sync + asyncify) and quickjs-ng release (sync + asyncify). quickjs-ng debug and the packaging/browser/example jobs were not run locally.