docs: record that master is PR-protected in AGENTS.md - #2386
Open
just-jeb wants to merge 1 commit into
Open
Conversation
A ruleset requires changes to reach master through a pull request with a passing ci-pass check, but Jeb is a bypass actor, so a direct push succeeds and only mentions the bypass in its output. That is how the previous AGENTS.md commit landed straight on master. Also records that querying the branch rules as a bypass actor returns an empty list, which reads as 'unprotected' and is not. Committed with --no-verify: husky could not resolve lint-staged after the branch switch, and the documented fix (yarn install) cannot run because registry.npmjs.org is unreachable from this machine right now.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
masteris covered by a repository ruleset requiring every change to arrive via apull request with a passing
ci-passcheck. Nothing inAGENTS.mdsays so.Because the repo owner is a bypass actor, a direct
git push origin mastersucceeds — it only mentions the bypass in its output. And
gh api repos/just-jeb/angular-builders/rules/branches/masterreturns[]for abypass actor, so checking for protection the obvious way reports none.
Between those two, an agent session has no signal that the rule exists. That is how
the preceding commit (
20642239, the AGENTS.md local-failure-triage addition) landedstraight on master during a context migration.
What is the new behavior?
A
MUST NEVER: Push straight to masterinvariant, which states the ruleset, saysexplicitly that the guard does not stop a bypass actor, notes that it covers
docs-only commits, and warns that an empty rules list is not evidence of an
unprotected branch.
20642239is left in place — its content is wanted, and rewriting already-pushedhistory costs more than it fixes. This PR closes the knowledge gap that produced it,
and does so through the process it documents.
Does this PR introduce a breaking change?
Other information
Committed with
--no-verify. Husky could not resolvelint-stagedafter the branchswitch, and the documented fix (
yarn install) cannot run right now:registry.npmjs.orgis unreachable from this machine, while the Cloudsmith proxyanswers 401. AGENTS.md's own Local Failure Triage section names that as the one case
where
--no-verifyis appropriate. The change is a single prose block in a markdownfile, so nothing was skipped that matters — but it does want prettier's blessing from
CI.