Skip to content

Stage 2 - remove gh-pages#141

Merged
mbabker merged 2 commits into
joomla:gh-pagesfrom
brianteeman:gh-pages
Feb 16, 2017
Merged

Stage 2 - remove gh-pages#141
mbabker merged 2 commits into
joomla:gh-pagesfrom
brianteeman:gh-pages

Conversation

@brianteeman

Copy link
Copy Markdown
Contributor

This is stage 2 of the move from gh-pages.

Please dont merge until after step 1 has been merged AND until it has been added to dev.j.o

@mbabker

mbabker commented Nov 19, 2016

Copy link
Copy Markdown
Contributor

Just say when...

@brianteeman

brianteeman commented Nov 19, 2016 via email

Copy link
Copy Markdown
Contributor Author

@brianteeman

Copy link
Copy Markdown
Contributor Author

Hit a bug in the component with alias generation so it wont be today

@photodude

Copy link
Copy Markdown
Contributor

Should also deal with the open PR's that affect the GH-pages see PR #61, PR #78, PR #89, and PR #91

@mbabker

mbabker commented Feb 11, 2017

Copy link
Copy Markdown
Contributor

Ready for review - https://developer.joomla.org/coding-standards.html

@zero-24

zero-24 commented Feb 12, 2017

Copy link
Copy Markdown
Contributor

Looks great. 👍 Do we have a change for syntax higlyting?

syntax

@mbabker

mbabker commented Feb 12, 2017

Copy link
Copy Markdown
Contributor

GitHub's pages have syntax highlighting integrated into its CSS. We'll need to add a CSS library for it to do the same.

@mbabker

mbabker commented Feb 12, 2017

Copy link
Copy Markdown
Contributor

All we might need is https://github.com/joomla/jissues/blob/master/www/media/css/code.css which we use on the issue tracker for our markdown demo pages - https://issues.joomla.org/markdown (code tab)

@mbabker

mbabker commented Feb 12, 2017

Copy link
Copy Markdown
Contributor

Actually, that CSS is based on an old version of GitHub's markdown parser, it isn't really good anymore.

I did test out https://github.com/primer/github-syntax-light quickly and it does the job adequately. I can add loading that to our layout override later on.

@photodude

Copy link
Copy Markdown
Contributor

Page one

Contributing to this manual

If you want to contribute and improve this manual, you can find the source files at https://github.com/joomla/coding-standards/tree/gh-pages.

I'm assuming this section needs to be updated

Other than the syntax highlighting, it looks fairly good. We also have a new PR to include covering SCSS See #146

@zero-24

zero-24 commented Feb 12, 2017

Copy link
Copy Markdown
Contributor

About the section Contributing to this manual i have noted this in the other issue too. But atm this is only a 1v1 copy of the content :)

@mbabker

mbabker commented Feb 16, 2017

Copy link
Copy Markdown
Contributor

I've added the CSS for the syntax highlighting. Content updates can be handled as pull requests to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants