fix: parse named params by rune; support :name::type casts#996
Open
sonnemusk wants to merge 1 commit into
Open
fix: parse named params by rune; support :name::type casts#996sonnemusk wants to merge 1 commit into
sonnemusk wants to merge 1 commit into
Conversation
compileNamedQuery previously walked the query byte-wise, so multi-byte Unicode parameter names (e.g. :名前) were broken, and a PostgreSQL cast immediately after a named parameter (:id::int) failed with an unexpected colon error. Parse names with utf8.DecodeRune, and treat '::' after a completed name as a literal cast rather than a new bind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compileNamedQueryhad two related bugs called out in-tree (FIXME + commented failing test) and in #983::あ,:名前).:id::inthitunexpected ':' while reading named parambecause the first cast colon was treated as a new name start.Changes
utf8.DecodeRune::, end the bind and emit the cast literally:id::int/:name::textcaseTest plan
go test -count=1 -run TestCompileQuery .go test -count=1 -short .