Repository navigation
JGC-499 - Replace 'safe to test' label with single build-gate environment approval #3535
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,200 @@ | ||
| name: Build Gate | ||
| # Single approval gate for fork/PR runs: a maintainer approves the `build-gate` | ||
| # environment deployment once, releasing frogbot and every integration-test suite. | ||
| # Replaces the per-workflow 'safe to test' label mechanism. | ||
| on: | ||
| pull_request_target: | ||
| types: [opened, synchronize, reopened] | ||
| branches: | ||
| - "master" | ||
| push: | ||
| branches: | ||
| - "master" | ||
| workflow_dispatch: | ||
|
|
||
| # Ensures that only the latest commit is running for each PR at a time. | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| pull-requests: write | ||
| contents: read | ||
|
|
||
| jobs: | ||
| # The single approval point. `build-gate` carries the Required-reviewers rule. | ||
| # Trusted push & manual dispatch skip approval (empty environment name = no gate). | ||
| gate: | ||
| name: Approval gate | ||
| runs-on: ubuntu-latest | ||
| environment: ${{ github.event_name == 'pull_request_target' && 'build-gate' || '' }} | ||
| steps: | ||
| - run: echo "Approved — releasing frogbot and integration suites." | ||
|
|
||
| # ---- Suites (each fans out behind the single gate) ---------------------- | ||
| frogbot: | ||
| needs: gate | ||
| uses: ./.github/workflows/frogbot-scan-pull-request.yml | ||
| secrets: inherit | ||
|
|
||
| access: | ||
| needs: gate | ||
| # OIDC suite: caller must grant id-token so the reusable workflow can request it. | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| uses: ./.github/workflows/accessTests.yml | ||
| secrets: inherit | ||
| artifactory: | ||
| needs: gate | ||
| uses: ./.github/workflows/artifactoryTests.yml | ||
| secrets: inherit | ||
| conan: | ||
| needs: gate | ||
| uses: ./.github/workflows/conanTests.yml | ||
| secrets: inherit | ||
| distribution: | ||
| needs: gate | ||
| uses: ./.github/workflows/distributionTests.yml | ||
| secrets: inherit | ||
| docker: | ||
| needs: gate | ||
| uses: ./.github/workflows/dockerTests.yml | ||
| secrets: inherit | ||
| evidence: | ||
| needs: gate | ||
| uses: ./.github/workflows/evidenceTests.yml | ||
| secrets: inherit | ||
| ghost-frog: | ||
| needs: gate | ||
| uses: ./.github/workflows/ghostFrogTests.yml | ||
| secrets: inherit | ||
| go: | ||
| needs: gate | ||
| uses: ./.github/workflows/goTests.yml | ||
| secrets: inherit | ||
| gradle: | ||
| needs: gate | ||
| uses: ./.github/workflows/gradleTests.yml | ||
| secrets: inherit | ||
| helm: | ||
| needs: gate | ||
| # OIDC suite: caller must grant id-token so the reusable workflow can request it. | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| uses: ./.github/workflows/helmTests.yml | ||
| secrets: inherit | ||
| huggingface: | ||
| needs: gate | ||
| # OIDC suite: caller must grant id-token so the reusable workflow can request it. | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| uses: ./.github/workflows/huggingfaceTests.yml | ||
| secrets: inherit | ||
| lifecycle: | ||
| needs: gate | ||
| uses: ./.github/workflows/lifecycleTests.yml | ||
| secrets: inherit | ||
| maven: | ||
| needs: gate | ||
| uses: ./.github/workflows/mavenTests.yml | ||
| secrets: inherit | ||
| nix: | ||
| needs: gate | ||
| uses: ./.github/workflows/nixTests.yml | ||
| secrets: inherit | ||
| npm: | ||
| needs: gate | ||
| uses: ./.github/workflows/npmTests.yml | ||
| secrets: inherit | ||
| nuget: | ||
| needs: gate | ||
| uses: ./.github/workflows/nugetTests.yml | ||
| secrets: inherit | ||
| oidc: | ||
| needs: gate | ||
| # OIDC suite: caller must grant id-token so the reusable workflow can request it. | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| uses: ./.github/workflows/oidcTests.yml | ||
| secrets: inherit | ||
| plugins: | ||
| needs: gate | ||
| uses: ./.github/workflows/pluginsTests.yml | ||
| secrets: inherit | ||
| pnpm: | ||
| needs: gate | ||
| uses: ./.github/workflows/pnpmTests.yml | ||
| secrets: inherit | ||
| podman: | ||
| needs: gate | ||
| uses: ./.github/workflows/podmanTests.yml | ||
| secrets: inherit | ||
| poetry: | ||
| needs: gate | ||
| uses: ./.github/workflows/poetryTests.yml | ||
| secrets: inherit | ||
| python: | ||
| needs: gate | ||
| uses: ./.github/workflows/pythonTests.yml | ||
| secrets: inherit | ||
| script: | ||
| needs: gate | ||
| uses: ./.github/workflows/scriptTests.yml | ||
| secrets: inherit | ||
| transfer: | ||
| needs: gate | ||
| uses: ./.github/workflows/transferTests.yml | ||
| secrets: inherit | ||
| uv: | ||
| needs: gate | ||
| uses: ./.github/workflows/uvTests.yml | ||
| secrets: inherit | ||
|
|
||
| # Single, stable required status check. Point branch protection at | ||
| # "Build Gate / build-gate-success" instead of the matrix-expanded suite checks. | ||
| # Recover a failed suite with "Re-run failed jobs" (re-runs the suite + this job, | ||
| # not the approval gate) — no re-approval and no new commit needed. | ||
| build-gate-success: | ||
|
Contributor
There was a problem hiding this comment. Can we add gate also here?
Contributor
Author
There was a problem hiding this comment. Done in |
||
| name: build-gate-success | ||
| if: always() | ||
|
Contributor
There was a problem hiding this comment. The if: always () cusing an issue here
Contributor
Author
There was a problem hiding this comment. Good catch. Fixed in |
||
| needs: | ||
| - gate | ||
| - frogbot | ||
| - access | ||
| - artifactory | ||
| - conan | ||
| - distribution | ||
| - docker | ||
| - evidence | ||
| - ghost-frog | ||
| - go | ||
| - gradle | ||
| - helm | ||
| - huggingface | ||
| - lifecycle | ||
| - maven | ||
| - nix | ||
| - npm | ||
| - nuget | ||
| - oidc | ||
| - plugins | ||
| - pnpm | ||
| - podman | ||
| - poetry | ||
| - python | ||
| - script | ||
| - transfer | ||
| - uv | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Verify no suite failed or was cancelled | ||
| run: | | ||
| if ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}; then | ||
| echo "::error::One or more suites failed or were cancelled." | ||
| exit 1 | ||
| fi | ||
| echo "All suites succeeded (skipped suites are allowed)." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there is a bug here (not security)
I remember that the caller workflow cannot assign permissions it doesn't have
In that case, the caller does not have id-token: write, and it assigns it to a different workflow like .github/workflows/helmTests.yml by triggrering it
https://github.com/jfrog/jfrog-cli/pull/3535/changes#diff-b4f30d948e9602b6e03aa68700eb3589067e5fabe411faa596842e3bcf0de387R22 row 22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Fixed in
27645d29by grantingid-token: writeper-job on the four OIDC suites (access,helm,huggingface,oidc).