Fix Geo IP API build issue#1838
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI build scope to include the Geo IP API and related cron tasks so CI catches build breakages for those services, and it adjusts Prisma error subclasses in the Prisma library.
Changes:
- Add
geo-ip-apiandcron-tasksto thebuild:ciNxrun-manyproject list. - Remove the
overridemodifier from Prisma error subclasses’codefields inlibs/prisma.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Expands CI build to include geo-ip-api and cron-tasks Nx projects. |
| libs/prisma/src/lib/prisma-errors.ts | Adjusts Prisma error subclass code field declarations (modifier change) to address build/type compatibility. |
b59112e to
5337de3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix prisma-errors type overrides on
codeto prevent typescript compile error for geo-api service