ci: replace unmaintained github-tag-action with plain git tag/push#2887
Merged
Conversation
The edge release job only used the action to create and push a pre-computed tag (EDGE_TAG), not its semver auto-bump feature. The action is unmaintained (last release Mar 2024) and runs on the soon-to-be-deprecated Node 20. Replace it with two git commands, which do exactly what was being used today with no third-party dependency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…-action-alternative # Conflicts: # .github/workflows/cli-release.yml
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI release GitHub Actions workflow to stop using the unmaintained mathieudutour/github-tag-action and instead create/push the precomputed edge tag using plain git, keeping the edge release flow functionally equivalent while removing the action dependency.
Changes:
- Remove
mathieudutour/github-tag-actionusage for edge tag creation. - Add direct
git tag+git pushcommands to create and pushEDGE_TAG.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+60
to
+62
| run: | | ||
| git tag "$EDGE_TAG" | ||
| git push origin "$EDGE_TAG" |
Collaborator
Author
There was a problem hiding this comment.
Good call — made the step idempotent in 0ddcaf1. git tag -f plus git push -f origin refs/tags/$EDGE_TAG so a same-day rerun overwrites the existing tag instead of failing, and the explicit refs/tags/ ref removes the ambiguity.
Force-update the tag and push an explicit ref so a same-day rerun (when the edge tag already exists) doesn't fail. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The edge release job only used
mathieudutour/github-tag-actionto create and push a pre-computed tag (EDGE_TAG), not its semver auto-bump feature. That action is unmaintained (last release Mar 2024) and runs on the soon-to-be-deprecated Node 20, so this replaces it with two plaingitcommands that do exactly what was being used. The existingcontents: writepermission and defaultGITHUB_TOKENfrom checkout cover pushing the tag, and the step's outputs weren't referenced elsewhere.How was it tested?
Static review of the workflow — the change is a no-op on behavior, swapping the action for the equivalent
git tag/git pushit was performing. The full edge release path runs on the weekly schedule / manual dispatch.Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.