fix: Honour the remoteContextLookups option instead of typeChecking's value#5
Draft
jeswr wants to merge 1 commit into
Draft
fix: Honour the remoteContextLookups option instead of typeChecking's value#5jeswr wants to merge 1 commit into
jeswr wants to merge 1 commit into
Conversation
… value ComponentsManagerBuilder assigned `Boolean(options.typeChecking)` to `this.remoteContextLookups` whenever `options.remoteContextLookups` was defined - a copy-paste slip. As a result, passing `remoteContextLookups: true` together with `typeChecking: false` silently disabled remote context lookups (and conversely, `remoteContextLookups: false` with default type checking silently enabled them). Adds a regression test pinning the two options as independent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line correctness fix:
ComponentsManagerBuilderassignedBoolean(options.typeChecking)tothis.remoteContextLookupswheneveroptions.remoteContextLookupswas defined — a copy-paste slip.Effect of the bug:
remoteContextLookups: true+typeChecking: falsesilently disabled remote context lookups;remoteContextLookups: false+ default type checking silently enabled them (an unintended network-access toggle).Found while working in this file for #4; includes a regression test pinning the two options as independent. Full suite green, 100 % coverage retained.
Generated by an agent (Claude Fable 5) on @jeswr's behalf — staged on the fork for his review before upstreaming.
Review timing: This draft was prepared with Claude; I (@jeswr) will personally review it before it progresses. I'm currently batching a lot of work in flight, so expect active review Wednesday–Friday (8–10 July).