Skip to content

perf: Pre-expand the Override type and avoid Object.entries in the override scan (~1.9x) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jeswr wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

perf: Pre-expand the Override type and avoid Object.entries in the override scan (~1.9x) #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/preprocess/ConfigPreprocessorOverride.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { Resource } from 'rdf-object';
import type { RdfObjectLoader } from 'rdf-object/lib/RdfObjectLoader';
import { stringToTerm } from 'rdf-string';
import type { Logger } from 'winston';
import { IRIS_OO, PREFIX_OO } from '../rdf/Iris';
import { uniqueTypes } from '../rdf/ResourceUtil';
Expand Down Expand Up @@ -110,8 +111,13 @@ export class ConfigPreprocessorOverride implements IConfigPreprocessor<Resource[
* Finds all Override resources in the object loader and links them to their target resource.
*/
protected* findOverrideTargets(): Iterable<{ override: Resource; target: Resource }> {
for (const [ id, resource ] of Object.entries(this.objectLoader.resources)) {
if (resource.isA(IRIS_OO.Override) && resource.value !== IRIS_OO.Override) {
// Convert the Override type IRI to a term once, instead of having `Resource#isA`
// re-expand the type string for every resource in the loader.
// Iterating over the keys also avoids materializing a [ key, value ] pair array per resource.
const overrideType = stringToTerm(IRIS_OO.Override);
for (const id of Object.keys(this.objectLoader.resources)) {
const resource = this.objectLoader.resources[id];
if (resource.isA(overrideType) && resource.value !== IRIS_OO.Override) {
const targets = resource.properties[IRIS_OO.overrideInstance];
if (!targets || targets.length === 0) {
this.logger.warn(`Missing overrideInstance for ${id}. This Override will be ignored.`);
Expand Down
Loading