[CodeRabbit review] upstream #10452: Downgrade some error logs(release-8.5)

[jebter]

Review-only mirror of upstream PR pingcap#10452: pingcap#10452

The source and base branches are immutable review-only mirrors of the exact upstream head and base commits. Do not merge, close, modify, delete, force-push, or rebase this PR or its branches. The shared .coderabbit.yaml is review-enabling metadata only and is not an upstream code change.

Summary by CodeRabbit

• Operational Improvements

  • Reclassified several recoverable runtime and initialization conditions from errors to warnings, making logs more accurately reflect service impact while preserving existing handling and responses.
  • Updated an included TiFlash Proxy component reference.

• Chores

  • Added configuration for automated code review on designated release branches.

[coderabbitai]

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 4b7bb05e-6a9c-45d8-8d97-af9b12d3b17b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: c82f9e46-c1ce-444c-a5b1-08f1f5059c86

📥 Commits

Reviewing files that changed from the base of the PR and between d7123b9 and 640422e.

📒 Files selected for processing (10)

• .coderabbit.yaml
• contrib/tiflash-proxy
• dbms/src/DataStreams/CreatingSetsBlockInputStream.cpp
• dbms/src/Flash/Coprocessor/DAGDriver.cpp
• dbms/src/Flash/Mpp/MPPHandler.cpp
• dbms/src/Flash/Mpp/MPPTask.cpp
• dbms/src/Flash/ResourceControl/LocalAdmissionController.cpp
• dbms/src/Server/Server.cpp
• dbms/src/Storages/DeltaMerge/ReadThread/SegmentReader.cpp
• dbms/src/Storages/DeltaMerge/WriteBatchesImpl.h

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The changes lower selected exception and diagnostic log levels from error to warning. They also add automatic review configuration for matching release branches and advance the TiFlash proxy submodule reference.

Changes

Warning-level exception logging

Layer / File(s)	Summary
Query and MPP execution logging dbms/src/DataStreams/CreatingSetsBlockInputStream.cpp, dbms/src/Flash/Coprocessor/DAGDriver.cpp, dbms/src/Flash/Mpp/MPPHandler.cpp, dbms/src/Flash/Mpp/MPPTask.cpp	Selected set creation, DAG, MPP handler, and MPP task logs now use LOG_WARNING. Error responses and control flow remain unchanged.
Resource and schema operation logging dbms/src/Flash/ResourceControl/LocalAdmissionController.cpp, dbms/src/Server/Server.cpp	Watch, server cleanup, and schema synchronization logs now use LOG_WARNING. Retry and error handling behavior remain unchanged.
Storage diagnostic logging dbms/src/Storages/DeltaMerge/ReadThread/SegmentReader.cpp, dbms/src/Storages/DeltaMerge/WriteBatchesImpl.h	Segment read exceptions and non-empty write-batch diagnostics now use LOG_WARNING.

Review configuration

Layer / File(s)	Summary
Automatic review configuration .coderabbit.yaml	Enables automatic review for base branches matching the specified release pattern.

TiFlash proxy update

Layer / File(s)	Summary
Proxy submodule pointer contrib/tiflash-proxy	Advances the submodule reference to commit 3384030b6dbc184c4b0eecd6951798f17e1869f6.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 64042

This change lowers selected diagnostic logs from error to warning while preserving operational error handling and responses, adds scoped review configuration, and updates the pinned proxy revision. No concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 18.18% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 8 files. (2 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The description explains the review-only mirror and branch constraints, but it does not follow the repository template. It omits the problem summary, issue number, change details, checklist selections…	Add the required template sections. State the problem and issue number, describe the log-level changes, select the applicable checklist items such as No code or Manual test, document side effects and documentation impact, and include the re…

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the main change: downgrading selected error logs for release-8.5. The upstream PR reference and review label add context without making the title unclear.

Full details: Docstring Coverage

Explanation

Docstring coverage is 18.18% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 8 files. (2 skipped: 2 unsupported.)

Full details: Description check

Explanation

The description explains the review-only mirror and branch constraints, but it does not follow the repository template. It omits the problem summary, issue number, change details, checklist selections, side effects, documentation impact, and release note.

Resolution

Add the required template sections. State the problem and issue number, describe the log-level changes, select the applicable checklist items such as No code or Manual test, document side effects and documentation impact, and include the release note.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch coderabbit/release-8.5-pr-10452-config

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[jebter]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[jebter]

@coderabbitai full review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

---

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 2 minutes.

[jebter]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.