[CodeRabbit review] upstream #10450: Prefer local store for remote read coprocessor requests(release-8.5)

[jebter]

Review-only mirror of upstream PR pingcap#10450: pingcap#10450

The source and base branches are immutable review-only mirrors of the exact upstream head and base commits. Do not merge, close, modify, delete, force-push, or rebase this PR or its branches. The shared .coderabbit.yaml is review-enabling metadata only and is not an upstream code change.

Summary by CodeRabbit

• New Features

  • Coprocessor requests can now prefer a specific storage location, improving request routing behavior.

• Maintenance

  • Updated the bundled client component to a newer revision.
  • Added automated code review configuration for designated release branches.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 3a12d8c9-845a-4342-b5e4-2ff1343c4d6c

📥 Commits

Reviewing files that changed from the base of the PR and between da7182e and 251e8a6.

📒 Files selected for processing (4)

• .coderabbit.yaml
• contrib/client-c
• dbms/src/Flash/Coprocessor/CoprocessorReader.h
• dbms/src/Flash/Coprocessor/DAGStorageInterpreter.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Changes

Coprocessor store preference

Layer / File(s)	Summary
Propagate preferred store ID dbms/src/Flash/Coprocessor/CoprocessorReader.h, dbms/src/Flash/Coprocessor/DAGStorageInterpreter.cpp	CoprocessorReader accepts a preferred store ID and passes it to ResponseIter. buildCoprocessorReader supplies the local store ID.

Review configuration

Layer / File(s)	Summary
Configure automatic reviews .coderabbit.yaml	Automatic reviews are enabled for base branches matching coderabbit/release-8.5-base-*.

Client C reference

Layer / File(s)	Summary
Update client C pointer contrib/client-c	The submodule reference advances to commit d55cbe2461fa82c84f473445050249504f1002a6.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 251e8

This change prefers the local store for coprocessor remote reads while preserving existing construction behavior. No merge-blocking production or user-impact risk is currently identified.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains that this is an immutable review-only mirror, but it does not follow the repository template. It omits the problem summary, change details, test selection, side effects, docum…	Add the required template sections. Describe the problem and implementation, select at least one applicable test option, document side effects and documentation impact, and provide the release note. Retain the review-only mirror constraints…
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (2 skipped: 2 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: preferring the local store for remote-read coprocessor requests. The review prefix and release branch suffix add context but do not obscure the change.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains that this is an immutable review-only mirror, but it does not follow the repository template. It omits the problem summary, change details, test selection, side effects, documentation impact, and release note.

Resolution

Add the required template sections. Describe the problem and implementation, select at least one applicable test option, document side effects and documentation impact, and provide the release note. Retain the review-only mirror constraints as additional context.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (2 skipped: 2 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch coderabbit/release-8.5-pr-10450-config

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[jebter]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.