Fix const iterator value types - #1495
Open
fzlzjerry wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the iterator
value_typecv-unqualified so generic code usingstd::iterator_traits<It>::value_typecan collect const YAML ranges into astd::vector.Keep the existing cv-qualified dereference result for both forward and reverse iterators. Pointer/reference types, iterator categories and Node sharing behavior are unchanged. Changing the value-type alias alone would also remove const from both dereference results; the regression tests cover that distinction.
Validation
std::vector<const iterator_value>.git diff --checkpass.Closes #1326.