Fixes error undefined is not an object (evaluating '_react2.PropTypes.string')

[crim3hound]

Fixes error undefined is not an object (evaluating '_react2.PropTypes.string').
React Native Version: 0.51.0

[xiamx]

Do you want to rename the pull request title to "Fixes error undefined is not an object (evaluating '_react2.PropTypes.string')."? It would help other people finding this fix easily

[perry-mitchell]

This is excellent, thank you @anti-nerd - One problem though, it seems that this library does not yet reference prop-types in package.json.. Could you possibly add it? (not sure if it's suitable just as a peer dependency..) If not, react-native projects that only use basic components and no prop-types will throw errors I'm guessing. Having it as a peer dependency would at least warn them.

[perry-mitchell]

@jaysoo I'm sorry to pester you, but would you have an ETA for when this might be merged and released?

[crim3hound]

You're welcome @perry-mitchell, and I believe that's true since it seems that it's newer versions of RN that have a separate prop-types library. Let me look into that.

Alternatively, perhaps @jaysoo can update the library to use prop-types as one of the dependencies instead? This way the package.json would also be updated.

[perry-mitchell]

I've released a fork of this repo under @perrymitchell/react-native-prompt, in case it might temporarily help someone, as I've needed to continue with other features and couldn't wait for this PR to be merged.

[DikshaDeep]

Please update the package and close this issue

[perry-mitchell]

@jaysoo Any chance of a quick merge and release? Seems like a really harmless PR. I would quickly close my fork in favour of this feature going out..

[xlogix]

Is this merged?