Skip to content

Remove superfluous code - #48

Merged
j9t merged 2 commits into
mainfrom
chore/remove-dead-code
Oct 26, 2026
Merged

j9t merged 2 commits into
mainfrom
chore/remove-dead-code

Conversation

@j9t

@j9t j9t commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Changed
    • CLI processing now uses the configured pool sizing directly while keeping work limited to available queued items.
    • Fix-pass results no longer include an empty findings value, and fix summaries no longer suppress matching outcome details.
    • Warning messages continue to display the same scope information.
    • Other changes do not affect behavior visible to end users.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e9d1323e-4a38-4924-81c5-d259b6ca84a4
Commits

Reviewing files that changed from the base of the PR and between bed1a21 and a6b8944.

Files selected for processing: 12
  • CHANGELOG.md
  • src/cli/pool.js
  • src/cli/render.js
  • src/consolidate.js
  • src/lib/hacks.js
  • src/lib/normalization.js
  • src/lib/scopes.js
  • src/lib/selectors.js
  • src/lib/shorthands.js
  • src/lib/transaction.js
  • src/merge.js
  • src/plugin.js
Files with no reviewable changes: 1
  • src/cli/render.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The changes simplify conditions and assignments across the engine, CLI, and plugin. They also alter snapshot storage, make several exports module-local, update cache references, and add an Unreleased changelog entry.

Changes

Engine and CLI Cleanup

Layer / File(s) Summary
Rule merging and rollback state
src/merge.js, src/lib/transaction.js
Merge operations assign selected values unconditionally, several merge functions become module-local, and snapshots store rule state directly for rollback.
Normalization and consolidation
src/consolidate.js, src/lib/normalization.js
Decimal normalization no longer captures and reattaches a leading minus sign. The zero-to-none check and aggressive-mode guard are simplified.
Internal exports and cache references
src/lib/hacks.js, src/lib/scopes.js, src/lib/shorthands.js, src/lib/normalization.js, src/lib/selectors.js
Several constants and functions become module-local. Cache comments refer to caches.js.
CLI and plugin cleanup
src/cli/pool.js, src/cli/render.js, src/plugin.js, CHANGELOG.md
The CLI changes worker-count and summary construction. Plugin warnings use scope values directly. The changelog records the cleanup.

Priority: Low

Change: Refactor

Merge Risk: Minimal · up to a6b89

No merge-blocking behavior change is established; the cleanup is suitable for merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Remove superfluous code" matches the main change. The PR removes dead and no-op code across the engine, CLI, and plugin, including redundant guards, unused fields and arguments, identical-b…
Docstring Coverage Passed Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 10 files. (1 skipped: 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Remove superfluous code" matches the main change. The PR removes dead and no-op code across the engine, CLI, and plugin, including redundant guards, unused fields and arguments, identical-branch conditionals, and unused exports. The title is short, specific to the change type, and a teammate scanning history would understand the primary intent. Minor note: it does not name the affected areas, which is acceptable for a cleanup PR.

Full details: Docstring Coverage

Explanation

Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 10 files. (1 skipped: 1 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@j9t
j9t merged commit 01c039b into main Oct 26, 2026
6 checks passed
@j9t
j9t deleted the chore/remove-dead-code branch October 26, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant