Conversation
msdemlei
left a comment
msdemlei
left a comment
There was a problem hiding this comment.
I've not looked at the scripts in tests (should I?). For the rest, I have a couple of comments and suggestions. Feel free to ignore what you disagree with...
There was a problem hiding this comment.
Avoid commenting out stuff like this in version-controlled documents; you can always pull back stuff from the history if necessary. Anyway: you intended for this to be gone last november :-)
There was a problem hiding this comment.
Again, I would prefer deletions to commenting out, but sentence looks very much incomplete even after eliminating the comments. It "this mapping is illustrated..."?
| \caption{\xmlel{INFO} names available for specifying the query that | ||
| generated a VOTable} | ||
| %\caption{\xmlel{INFO} names available for specifying the query that generated a VOTable} | ||
| \caption{\xmlel{INFO} names for specifying the query that generated a VOTable} % shorter to let place to put the table2 |
There was a problem hiding this comment.
This comment is a bit mystifying. Do you mean "leave space"? But you comment about this?
There was a problem hiding this comment.
Another mystifying comment: What is it that was removed? And why should there be a comment about it?
There was a problem hiding this comment.
s/resourcd/resource/. But frankly, I'd like it better if we spelled out what "is_derived_from" means: "if the originating resource was produced using data from the reference resource" or so.
| It is expressly allowed to supply data origin in individual | ||
| \xmlel{TABLE} or \xmlel{RESOURCE} elements in more complex VOTables. | ||
|
|
||
| For best practice, the global items listed in Table \ref{tab:query-names} should be placed directly at the root of the VOTable document. If a VOTable document contains several resources or tables, the items listed in Table \ref{tab:origin-names} can be placed in their respective resources or tables. |
There was a problem hiding this comment.
I'd write "As a best practice".
There was a problem hiding this comment.
I'd prefer "A scholarly publication to cite when the data is used".
There was a problem hiding this comment.
Uh... that's a lot of text that is only loosely related to rights_uri. Copyright is, that's right, the basis of licensing, but that's it. right_uri, on the other hand, is a simple URI to a license. We don't say who is the licensor, which is something of a problem. In that sense, we should just say: "A machine-readable identifier for the usage and distribution conditions; within the VO, use SPDX URIs".
gilleslandais
left a comment
gilleslandais
left a comment
There was a problem hiding this comment.
remove some comments, accepts "source" definition and propose a new text for 'is_derived_from'
2 participants
No description provided.