Update STATIC workflow for new water mask spec#334
Open
nemo794 wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for fixing the bug @nemo794 . Would you please confirm if you or Max have run this PR on one example and the water mask is fixed? |
|
@hfattahi I was able to run this PR last week on 4 examples, which I uploaded to S3. Has anyone had the chance to take a look? |
Contributor
Author
|
Using the HDF5s @jplzhan generated with this PR in the production pipeline, it appears that the water mask values are corrected for the water mask. Below are screenshots from those granules, where Blue:Water and Brown:Not Water
|
Contributor
Author
|
I also added a fresh commit, which makes the classification values explicit in the STATIC runconfig's comments. (No code logic change.) @hfattahi @oberonia78 Could you please re-review when you have a chance? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This PR updates to the STATIC Workflow to reflect the current specification for the NISAR Water Mask, which uses the classifications (Per JPL D-107710):
Background
When the Static Workflow was originally implemented in #144 , the classification used by the NISAR water mask at that time was:
isce3/python/packages/nisar/static/water_mask.py
Lines 21 to 24 in bdf1f6f
However, for the current water mask TIFF files being used in mission operations, 0 designates not-water, and 1-200 designates water. Here is a screenshot of
NISAR_water_mask_N33_N34_W119_W118_30m_v0.5.0.tif, provided by M Zahn:Due to this discrepancy, the static layers workflow was generating
waterMasklayers with the binary values 0 and 1 inverted. This PR resolves the issue.