Make Set trait generic - #986
Open
GruffElixir wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
The project tests, lint, Codecov, and downstream ipython/ipywidgets/nbconvert/notebook checks are passing. The two remaining failures appear external or transient: Read the Docs stopped during checkout with "fatal: reference is not a tree: b16490a", and the jupyter_server downstream job had one kernel-cull timing failure after 1,153 passes. Could a maintainer rerun those checks when convenient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #927
Make Set preserve its element type parameter, matching List and the other container traits. This enables annotations such as values: Set[str] = Set() to expose Set[str] on the class and set[str] on instances.
Tests: python -m pytest tests/test_typing.py -q