Conversation
* Generate diffs in case of transformation- or error output mismatch * Report only diffs (everything else is pretty much useless) * Suppress stderr in error tests (it's captured in diff anyway) Based on work by @a-v-popov in #3405
There was a problem hiding this comment.
Pull request overview
This PR updates the transformation/error pytest harness to reduce noisy CI output by emitting a unified diff on mismatches and suppressing stderr during error-case execution.
Changes:
- Replace direct
assert actual == expectedcomparisons with areport_mismatch(...)helper that builds adifflib.unified_diffand fails withpytest.fail(..., pytrace=False). - Suppress stderr during
run_test(...)execution for error cases viaredirect_stderr(...).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on work by @a-v-popov in #3405