Repository navigation
Conversation
…to avoid extra tab stops
… fab-button, item-option, router-link, segment-button and tab-button
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31623
What is the current behavior?
Currently, setting
tabindex="0"onion-button,ion-back-button,ion-menu-button,ion-select, or a clickableion-itemorion-cardleaves it on the host, so the host becomes its own tab stop in front of the native<button>or<a>inside the shadow root. With Full Keyboard Access on iOS, each of these controls takes two Tab presses, and the first stop has no accessible name.What is the new behavior?
tabindexon the host now moves to the native element, so each control is a single tab stop with the right name. It also stays off the host when a framework binding writes it after load.tabindexstays on the host, where it already takes the control out of the tab order and where the overlay focus trap andfocusManagerPriorityexpect to find it.ion-itemorion-cardthat isn't clickable has no native button or link, so it keepstabindexon the host like before.We do this with a new
createTabindexController, built oncreateAttributeController, which now takes amoveFromHostcheck that decides per value whether an attribute moves off the host or stays there.Does this introduce a breaking change?
Other information
This doesn't change the other case from the issue, where a button with no
tabindexis skipped by plain Tab in WKWebView, since that's WebKit's default behavior.