Repository navigation
Conversation
…ot a stale pathname match
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31696
What is the current behavior?
Currently, a page that mounts in the same render as a navigation registers with the previous pathname, since the outlet's route info catches up a render later. If a sibling catch-all route matched that old path, the page gets attached to the catch-all's view and hidden along with it, so the screen goes blank. Logging out and navigating in the same click is the usual way to hit it.
What is the new behavior?
Each view now passes itself to
registerIonPage, and the outlet uses that view when the path lookup picks a different one. When the two agree nothing changes, so the fix for #28878 still works. The new parameter onStackContextState.registerIonPagein@ionic/reactis optional, so existing callers are unaffected.Does this introduce a breaking change?
Other information
The new test fails without this change. It also runs a layout with no catch-all, because always trusting the owning view broke that case about half the time.