Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 of 2 tasks
1 of 2 tasks
ShaneK
requested changes
Nov 2, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Looks good overall, the icon-only sizes hold up across every size and theme! Just a couple of things, mainly wrapped text no longer naming the button for screen readers.
ShaneK
approved these changes
Nov 9, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks for the fixes, just one small nit on a comment!
| } | ||
|
|
||
| /** | ||
| * Text can't be selected, so the default slot passes it a zero font size. |
Member
There was a problem hiding this comment.
Suggested change
| * Text can't be selected, so the default slot passes it a zero font size. | |
| * `::slotted()` can't target bare text, so the default slot gives it a zero font size. |
Nit: I read "selected" as user selection at first, since the host sets user-select: none, and that makes the font size rule look like a duplicate of the visually-hidden() one. Removing it would bring bare text back though, because ::slotted() only hides elements. Up to you!
…838-icon-only # Conflicts: # BREAKING.md
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
An icon-only button renders anything else placed in it: text, icons in the
startandendslots, and badges without averticalposition. That content breaks the square shape, as raised in the review of #31043.What is the new behavior?
icon-onlyslot shows only that icon and any badge with averticalpositionstartandendslots aren't rendered. Text and other content without a slot are visually hidden, and the button keeps its square size<span>or<ion-label>Does this introduce a breaking change?
A button with an icon in the
icon-onlyslot now shows only that icon and any badge with averticalposition. Text, elements in thestartandendslots, and other content are hidden. Text and elements without a slot are only visually hidden, so they still name the button for assistive technology. To show other content, remove theicon-onlyslot and use thestartorendslot for the icon.Other information