Repository navigation
feat(viewer): fill the host container, stack the sidebar on narrow hosts, localize panel notices, and fix the phone navbar and playback bar - #80
Merged
Conversation
… panels in narrow containers
…gets that own them Text fields, composite widgets (tabs, sliders, radios, menus, lists) and dialogs keep Space and the arrow keys; buttons and links keep Space for activation, so a focused button never also toggles playback. Ctrl/Cmd chords without Alt and IME composition are left to the browser and the host (for example Cmd+Arrow navigation). Ctrl/Cmd never had a playback meaning on its own: it only selects the 100 ms time step together with Alt (Alt+Ctrl/Cmd+Arrow), which still works and is covered by a test.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
rosview | 924e774 | Commit Preview URL Branch Preview URL |
Oct 17 2026, 01:59 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
useStackedLayouthook measures the viewer's own content box (ResizeObserver, measured before first paint):IterablePlayerandWorkerSerializedSourcelogs at debug level. Navigating away while a file loads no longer prints errors; real failures still log as errors.tests/embed-layout.spec.ts.mainafter merge.Each commit typechecks and passes
check:i18non its own.Why
When the viewer was embedded in a fixed-size or resizable pane:
Tests
New tests:
tests/embed-layout.spec.ts:useStackedLayout.test.tsx,useKeyboardShortcuts.test.ts(ownership by role and element, Space on buttons and links, the Ctrl/Cmd and Alt rule, IME, cross-realm),imageStatusText.test.ts,ThreeCanvas.test.tsx(zh WebGL notice), and the cancel-log tests inIterablePlayer.test.tsandWorkerSerializedSource.test.ts.Checks run locally:
check:audit,check:i18n,lint,typecheck,test(vitest),build,build:lib,test:e2e(Playwright).Manual pass in Chrome on the standalone app and on an embedded build: