Repository navigation
feat(viewer): fill the host container, stack the sidebar on narrow hosts, and leave keys to focused controls - #97
Merged
Merged
Conversation
The source-map-js bump is dev tooling only and not user-visible, so it has no changeset (.changeset/README.md: one per user-visible package change).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.lerobot-rootnow fills its container. The viewer measures its own width with a@container/viewerquery, not the window:aria-orientation,aria-valuenow,aria-valueminandaria-valuemax, and arrow keys resize it.sm, the playback-bar toggle and GitHub link are hidden.source-map-jsto 1.2.2 (GHSA-68fv-2mgg-jv7q). This is dev-only, so it has no changeset.embed-fill-host(minor),shortcuts-own-keys(patch) andnavbar-phone-title(patch).webInitialJsgzip rises to 745,000 bytes andlibEntryraw to 405,000 bytes (+5 KB each). The layout, splitter and shortcut code bring both level with their previous ceilings.The version bump and CHANGELOG are not in this PR. Following the repo's changesets flow, they belong to the separate release PR.
Why
When the viewer was embedded in a fixed-size or resizable pane:
Tests
New and updated tests:
tests/browser/embed-layout.browser.spec.tsx:tests/browser/space-on-controls.browser.spec.tsx, on the real viewer:tests/browser/shortcut-target.browser.spec.ts: role and element ownership, including Space on button, link,role="button"andsummary, and cross-realm elements.tests/browser/navbar-title.browser.spec.tsx: no overlap at 390 px and 1280 px.tests/resizable-sidebar.spec.tsandtests/embed-root-sizing.spec.ts(the.lerobot-rootrule in the built CSS).Checks run locally:
format:check,check:docs-i18n,lint,typecheck,api:report:check,test:coverage,build:lib,check:package,build,check:bundle-size,test:browser.Manual pass in Chrome on the standalone app and on an embedded build:
Note for consumers
The
@zip.js/zip.jsrange is unchanged (^2.8.51), so fresh installs currently resolve to 2.24.0. Some npm mirrors may not carry that release yet. Pinning 2.23.0 throughoverrides(npm) orpnpm.overridesworks in the meantime.