Conversation
Removes the 5,000-member cap on cluster selection; the selected cluster is redrawn at full colour over a desaturated, faded map using scalar per-trace styles. A top-left chip names the selection and clears it (also Esc); overlays clear the center area's floating view selector.
lstein
requested review from
JPPhoto,
Pfannkuchensack and
blessedcoolant
as code owners
September 23, 2026 19:17
…mage-map-cluster-selection # Conflicts: # invokeai/frontend/webv2/src/workbench/image-map/imageMapTraces.ts # invokeai/frontend/webv2/src/workbench/widgets/image-map/ImageIndexProgress.tsx # invokeai/frontend/webv2/src/workbench/widgets/image-map/ImageMapPlot.tsx # invokeai/frontend/webv2/src/workbench/widgets/image-map/ImageMapWidgetView.tsx
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #301 (
perf/image-map-zoom); merge that first.On a large gallery, clicking a big cluster with "click selects cluster" on used to select only part of it.
MAX_CLUSTER_SELECTION = 5000silently kept the 5,000 members nearest the click. A user with a 170,000-image gallery saw most of each large cluster left unselected.● beaches · 336 items ✕). Its ✕ clears the selection, and so does Esc while the map has focus; the clear is also a palette command. Clearing drops the gallery's cluster listing, the same state the gallery's own chip clears, and restores the map's colours. Esc does nothing unless a cluster is selected, so it never wipes an ordinary search.--wb-center-chrome-inset. When the map is in the center panel, the floating view selector previously covered both.Why dimming is affordable
After #301, the base points are one trace per appearance, and every marker property is a scalar. The old highlight overlay carried per-point color and symbol arrays, which is the slow path #301 removed from the base points.
QA Instructions
Measurements: 170,000 synthetic points in real Chromium on a Radeon W7900 (ANGLE/EGL), with a GPU sync on every step.
Under SwiftShader (software GL), dimming zoomed faster than either outline variant at 100k: 128 ms, against 162 ms for a single-colour outline and 251 ms for the old outline.
Checks:
pnpm check:releasepasses:Limitations:
Review
Findings resolved:
Remaining limitations:
Checklist
What's Newcopy (if doing a release after this PR)