Repository navigation
Conversation
JPHutchins
reviewed
Oct 23, 2026
JPHutchins
left a comment
JPHutchins
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, probably needs the linters run.
I don't think we need these tests since it's all covered in smp/smpclient.
`smpmgr image slot-info` asks the server which images and slots the application can see, with their sizes (Zephyr's CONFIG_MCUMGR_GRP_IMG_SLOT_INFO, image management command 6). Assisted-by: Claude:claude-opus-5-5
`image slot-info` needs ImageSlotInfoRead from intercreate/smpclient#145, which in turn needs the slot info models from JPHutchins/smp#75. Neither is released yet, so take both from those pull requests' commits, so that CI can run. This is temporary: once both are released, drop it and move the smpclient pin to the release. smp is named here only because Poetry would otherwise take it from PyPI, where no release has slot info yet. cbor2 moves to 6, which smp has required since 4.2.0. Assisted-by: Claude:claude-opus-5-5
mniestroj
force-pushed
the
feat/image-slot-info
branch
from
October 24, 2026 13:32
7f7c305 to
f905fcc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smpmgr image slot-infoasks the server which images and slots the application can see, with their sizes (Zephyr'sCONFIG_MCUMGR_GRP_IMG_SLOT_INFO, image management command 6).