Repository navigation
fix(zkernel): make runtime assertions configurable - #62
Open
TenZeroToOnE wants to merge 1 commit into
Open
TenZeroToOnE wants to merge 1 commit into
TenZeroToOnE wants to merge 1 commit into
Conversation
Add CONFIG_ASSERT with a default of n. Disabled assertions do not evaluate their arguments. Include esp_rom_sys.h directly and suppress the unused timer result warning when assertions are disabled. Add regression tests, configuration documentation, and CI coverage for both settings. Fixes intercreate#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make __ASSERT and __ASSERT_NO_MSG conditional on CONFIG_ASSERT,
defaulting to n. Disabled assertions evaluate neither argument.
Include esp_rom_sys.h directly in kernel.h so esp_rom_delay_us
does not depend on assertion logging headers being included.
Preserve warning-free timer compilation with assertions disabled.
Add regression tests, configuration documentation, and CI coverage
for both assertion settings.
Validation on ESP-IDF v5.5.5:
1 intentionally ignored in each configuration.
and is skipped when disabled.
ESP-IDF v5.4 and on-device execution were not tested locally.
Fixes #33