Fix security and concurrency undefined behavior - #64
Open
mulugetam wants to merge 2 commits into
Open
Conversation
- Validate the dest_size extracted from the gzip-ext header in DetectGzipExt(). Reject the header when dest_size + HDRFTR_SIZE would exceed the input buffer length, preventing an OOB read by QPL/QATzip on malformed or malicious input. - Change ShardedMap from storing unique_ptr to shared_ptr and return a shared_ptr copy from Get(). The caller now holds a refcounted handle that keeps the object alive for the duration of its use, eliminating use-after-free when a concurrent deflateEnd/inflateEnd or address-reuse scenario destroys the map entry. - Update ShardedMap tests to use shared_ptr accordingly.
Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the dest_size extracted from the gzip-ext header in DetectGzipExt(). Reject the header when dest_size + HDRFTR_SIZE would exceed the input buffer length, preventing an OOB read by QPL/QATzip on malformed or malicious input.
Change ShardedMap from storing unique_ptr to shared_ptr and return a shared_ptr copy from Get(). The caller now holds a refcounted handle that keeps the object alive for the duration of its use, eliminating use-after-free when a concurrent deflateEnd/inflateEnd or address-reuse scenario destroys the map entry.
Update ShardedMap tests to use shared_ptr accordingly.