Repository navigation
Conversation
libqat is linked with -lnuma and -pthread, but libqat.pc lists neither. This does not affect shared linking, since libqat.so records its own dependencies, but a static link using "pkg-config --static --libs libqat" fails with undefined references to numa_available() and other libnuma functions. On glibc older than 2.34, libpthread is missing as well, and is only pulled in today because libcrypto.pc happens to add -pthread. Fix by adding -lnuma and PTHREAD_LIBS to Libs.private in libqat.pc. Signed-off-by: Kefu Chai <k.chai@proxmox.com>
gcabiddu
reviewed
Oct 12, 2026
gcabiddu
left a comment
gcabiddu
left a comment
Contributor
There was a problem hiding this comment.
Looks good. We are testing it internally. We might need to do something similar for pthreads on libusdm.pc.in. We can push an update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libqat is linked with -lnuma and -pthread, but libqat.pc lists neither. This does not affect shared linking, since libqat.so records its own dependencies, but a static link using
"pkg-config --static --libs libqat" fails with undefined references to numa_available() and other libnuma functions. On glibc older than 2.34, libpthread is missing as well, and is only pulled in today because libcrypto.pc happens to add -pthread.
Fix by adding -lnuma and PTHREAD_LIBS to Libs.private in libqat.pc.