Skip to content

[SYCL][Graph] Add missing calls for tracking native recording status and unit tests - #23160

Open
mmichel11 wants to merge 1 commit into
intel:syclfrom
adamfidel:matt/unit_test_in_order_deps
Open

mmichel11 wants to merge 1 commit into
intel:syclfrom
adamfidel:matt/unit_test_in_order_deps

Conversation

@mmichel11

Copy link
Copy Markdown
Contributor

Adds unit tests with our new framework for #22604. Also adds missing calls to check native recording status identified during unit testing:

  • Scheduler bypass memory ops
  • Handler submissions with non-kernel ops

This fix adds error messaging on handler-based submissions outside the graph which use a graph signal as a wait event (with a new compute runtime).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The critical queue recording-state issue and moderate mock undefined-behavior issue remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds native-recording status tracking for SYCL graph submissions, with expanded mocks and unit-test coverage.

Changes:

  • Tracks recording status for scheduler-bypass memory operations and handler submissions.
  • Extends mocks for wait-list and reusable-event tracing.
  • Adds dependency, lifecycle, and cross-context tests.
File summaries
File Summary Findings
sycl/unittests/Extensions/CommandGraph/NativeRecordingMock.hpp Extends trace data and APIs. None
sycl/unittests/Extensions/CommandGraph/NativeRecordingMock.cpp Captures wait lists and reusable events. Moderate (3 votes): avoid null pointer arithmetic for zero wait-list counts.
sycl/unittests/Extensions/CommandGraph/NativeRecording.cpp Adds native-recording behavior tests. None
sycl/source/detail/scheduler/commands.cpp Tracks status for handler-created events. None
sycl/source/detail/queue_impl.cpp Tracks status for scheduler-bypass memory events. Critical (2 votes): capture recording state before enqueue or combine pre- and post-enqueue state.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread sycl/source/detail/queue_impl.cpp Outdated
Comment thread sycl/unittests/Extensions/CommandGraph/NativeRecordingMock.cpp Outdated
@mmichel11
mmichel11 force-pushed the matt/unit_test_in_order_deps branch from 85a9b2d to b05ae63 Compare September 14, 2026 20:08
@mmichel11
mmichel11 marked this pull request as ready for review September 15, 2026 13:41
@mmichel11
mmichel11 requested review from a team as code owners September 15, 2026 13:41

@adamfidel adamfidel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants