Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The critical queue recording-state issue and moderate mock undefined-behavior issue remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds native-recording status tracking for SYCL graph submissions, with expanded mocks and unit-test coverage.
Changes:
- Tracks recording status for scheduler-bypass memory operations and handler submissions.
- Extends mocks for wait-list and reusable-event tracing.
- Adds dependency, lifecycle, and cross-context tests.
File summaries
| File | Summary | Findings |
|---|---|---|
sycl/unittests/Extensions/CommandGraph/NativeRecordingMock.hpp |
Extends trace data and APIs. | None |
sycl/unittests/Extensions/CommandGraph/NativeRecordingMock.cpp |
Captures wait lists and reusable events. | Moderate (3 votes): avoid null pointer arithmetic for zero wait-list counts. |
sycl/unittests/Extensions/CommandGraph/NativeRecording.cpp |
Adds native-recording behavior tests. | None |
sycl/source/detail/scheduler/commands.cpp |
Tracks status for handler-created events. | None |
sycl/source/detail/queue_impl.cpp |
Tracks status for scheduler-bypass memory events. | Critical (2 votes): capture recording state before enqueue or combine pre- and post-enqueue state. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mmichel11
force-pushed
the
matt/unit_test_in_order_deps
branch
from
September 14, 2026 20:08
85a9b2d to
b05ae63
Compare
mmichel11
marked this pull request as ready for review
September 15, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests with our new framework for #22604. Also adds missing calls to check native recording status identified during unit testing:
This fix adds error messaging on handler-based submissions outside the graph which use a graph signal as a wait event (with a new compute runtime).