Skip to content

[SYCL] Deprecate access::mode - #22803

Open
KornevNikita wants to merge 11 commits into
intel:syclfrom
KornevNikita:deprecate-access-mode
Open

[SYCL] Deprecate access::mode#22803
KornevNikita wants to merge 11 commits into
intel:syclfrom
KornevNikita:deprecate-access-mode

Conversation

@KornevNikita

@KornevNikita KornevNikita commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

access::mode is deprecated in SYCL 2020 in favor of access_mode.
Some enum entries are also deprecated - discard_write, discard_read_write and atomic.
access::mode should be defined as:

using mode = sycl::access_mode;

Align the implementation with SYCL 2020 under __INTEL_PREVIEW_BREAKING_CHANGES.
Update E2E tests to use no_init property for discard write.

@KornevNikita
[SYCL] Deprecate access::mode
b7466d0 
Deprecated in SYCL 2020 in favor of access_mode. Align implementation
with SYCL 2020 and deprecate some enum entries.
@KornevNikita
format
9ddef8d
@KornevNikita
breaking change. guard by preview macro
4eefb9a
@KornevNikita
one more guard
bbd439c
This was referenced Jul 30, 2026
Merged
Merged
Merged
Merged
Closed
Merged
Merged
sarnex pushed a commit that referenced this pull request Jul 30, 2026
@KornevNikita
[SYCL] Update Matrix tests to use access_mode (#22824)
ff6b33a 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803
KornevNikita added a commit that referenced this pull request Jul 31, 2026
@KornevNikita
[SYCL] Update Graph tests to use access_mode (#22826)
ffddb5c 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803
KornevNikita added a commit that referenced this pull request Jul 31, 2026
@KornevNikita
[SYCL] Update ESIMD tests to use access_mode (#22821)
b336d44 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803
KornevNikita added a commit that referenced this pull request Jul 31, 2026
@KornevNikita
[SYCL] Update dpcpp-tools tests (#22827)
084c454 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803
kswiecicki pushed a commit that referenced this pull request Jul 31, 2026
@KornevNikita
[SYCL] Update Adapters tests to use access_mode (#22822)
ffd5c97 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803
crystarm pushed a commit to crystarm/intel-llvm that referenced this pull request Jul 31, 2026
@KornevNikita @crystarm
[SYCL] Update Matrix tests to use access_mode (intel#22824)
4f04c31 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: intel#22803
crystarm pushed a commit to crystarm/intel-llvm that referenced this pull request Jul 31, 2026
@KornevNikita @crystarm
[SYCL] Update Graph tests to use access_mode (intel#22826)
d5fc31e 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: intel#22803
crystarm pushed a commit to crystarm/intel-llvm that referenced this pull request Jul 31, 2026
@KornevNikita @crystarm
[SYCL] Update ESIMD tests to use access_mode (intel#22821)
137adb4 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: intel#22803
crystarm pushed a commit to crystarm/intel-llvm that referenced this pull request Jul 31, 2026
@KornevNikita @crystarm
[SYCL] Update dpcpp-tools tests (intel#22827)
a89a441 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: intel#22803
KornevNikita added a commit to KornevNikita/llvm that referenced this pull request Jul 31, 2026
@KornevNikita
[SYCL] Update E2E to use access_mode
9b69625 
access::mode is deprecated in favor of access_mode.
PR to add deprecations intel#22803
This was referenced Jul 31, 2026
Merged
Merged
Merged
againull pushed a commit that referenced this pull request Jul 31, 2026
@KornevNikita
[SYCL] Update E2E to use access_mode [1/3] (#22842)
fd8a844 
access::mode is deprecated in favor of access_mode.
PR to add deprecations #22803
KornevNikita added a commit that referenced this pull request Aug 3, 2026
@KornevNikita
[SYCL] Update E2E to use access_mode [2/3] (#22843)
c882831 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803
1st - #22842
KornevNikita added a commit that referenced this pull request Aug 3, 2026
@KornevNikita
[SYCL] Update E2E to use access_mode [3/3] (#22844)
d603254 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803
1st - #22842
2nd - #22843
@KornevNikita
KornevNikita force-pushed the deprecate-access-mode branch from 3e34c59 to ab712e3 Compare August 3, 2026 12:11
sarnex pushed a commit that referenced this pull request Aug 4, 2026
@KornevNikita
[SYCL] Update Sanitizer tests to use access_mode (#22823)
978d04e 
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803
@KornevNikita
KornevNikita marked this pull request as ready for review August 4, 2026 16:10
@KornevNikita
KornevNikita requested a review from a team as a code owner August 4, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KornevNikita