[SYCL] Fix device image lifetime for jit_compiler - #22785
Merged
Conversation
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
KseniyaTikhomirova
requested review from
a team and
cperkinsintel
as code owners
July 28, 2026 12:56
sergey-semenov
approved these changes
Jul 28, 2026
This was referenced Jul 28, 2026
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
cperkinsintel
approved these changes
Jul 29, 2026
Contributor
Author
|
@intel/llvm-gatekeepers hi, could you please consider merging this. 1 job is failing but it seems to be an infrastructure issue. Thanks. |
crystarm
pushed a commit
to crystarm/intel-llvm
that referenced
this pull request
Jul 31, 2026
kernel_bundle feature uses createSYCLImages that adds image data to ProgramManager while device binaries are kept in jit_compiler singleton. jit_compiler instance was not attached to GlobalHandler and though can be destroyed earlier than ProgramManager resources are released. This PR aligns lifetime of jit_compiler and ProgramManager and adds regression E2E test for failing scenario. assisted by GH Copilot. --------- Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Contributor
|
@KseniyaTikhomirova We're seeing the below crash in the nightly, is it possible this PR is related? I didn't see any other changes to sycl-jit, 9084ec7 was in the previous nightly which passed. https://github.com/intel/llvm/actions/runs/30603364779/job/91074055301 Seeing this on multiple GPUs, all Linux though. |
Contributor
Author
this test was added in my PR so it is definitely related. Strange that precommit didn't show this. I will investigate. |
Contributor
|
thanks! |
Contributor
Author
|
revert commit is #22855 |
sarnex
pushed a commit
that referenced
this pull request
Aug 3, 2026
…22855) This reverts commit 5d03593. This fix is still valid and should be reapplied but jit_compiler uses sycl_jit library and we need to fix sycl_jit resources lifetime as well. sycl-jit uses singleton approach to store its resources. it the current state sycl_jit resources are destroyed before test static cache destruction happens and before sycl_jit library is unloaded. There is no perfect solution to make sycl_jit resources to live longer. Possible fixes are: introduce init/close to sycl_jit library to be able to control obj lifetime or use linux ctor/dtor priorities (as it is done for SYCL RT) where sycl-jit resources will be allocated/deallocated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kernel_bundle feature uses createSYCLImages that adds image data to ProgramManager while device binaries are kept in jit_compiler singleton. jit_compiler instance was not attached to GlobalHandler and though can be destroyed earlier than ProgramManager resources are released.
This PR aligns lifetime of jit_compiler and ProgramManager and adds regression E2E test for failing scenario.
assisted by GH Copilot.