Deprecate execution_capability and execution_capabilities - #22757
Deprecate execution_capability and execution_capabilities#22757mianowski wants to merge 6 commits into
Conversation
KornevNikita
left a comment
KornevNikita
left a comment
There was a problem hiding this comment.
Preliminary draft review.
| } | ||
| } | ||
|
|
||
| template <> std::string info_to_string(info::execution_capability info) { |
There was a problem hiding this comment.
I don't think we should remove code in this test. It's deprecated to encourage users to drop using this, although we're still supporting it.
There was a problem hiding this comment.
Please note the behavior is still tested in execution_capabilities_legacy.cpp, whereas it doesn't pollute this general smoke test
There was a problem hiding this comment.
I suggest to not create a new test, just keep this one and guard the code with __INTEL_PREVIEW_BREAKING_CHANGES
UPD. sorry there is no need for macro as we don't plan to remove this. We can just keep this code without macro. Changes to sycl/test/warnings/sycl_2020_deprecations.cpp should be enough.
This reverts commit 6995ac9.
2 participants
Covers #22735