Repository navigation
test(cli): pin the run/compare one-line help text, not just a label - #317
Merged
Merged
Conversation
The regex matched the command name followed by a cost label, so the test passed with no help text at all (summary_of returning None). Assert the literal lines the route table supplies. Signed-off-by: Alexander Rybkin <alexander.rybkin@intel.com>
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). Review details
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 279 279
Lines 36178 36178
Branches 6134 6134
=======================================
+ Hits 33907 33909 +2
+ Misses 1463 1462 -1
+ Partials 808 807 -1 🚀 New features to boost your workflow:
|
napetrov
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #284, which was merged before this could be pushed to its branch.
test_run_and_compare_have_a_one_line_help_in_the_top_level_listpins the changelog's "Changed" claim of #284:runandcompareget a one-line help indokimi --help. Its regex\S.* \[(free|paid)\]$also matches the command name followed by the cost label, so the test passes when the route table supplies no help text at all.summary_ofindokimi/cli_routes.pyreturnsNone.dokimi --helpprintsrun [free]and the test passes.The test now asserts the literal lines
Run the static benchmark spec and save a snapshot [free]andCompare two saved benchmark snapshots [free]. With the mutant above it fails, while the old test still passes. On main it passes, and so does the full suite. Test-only change, so there is no changelog fragment.